Simplify DefaultScopedContextProvider#2450
Closed
ppkarwasz wants to merge 2 commits intoScopedContextfrom
Closed
Conversation
Merged
Contributor
Author
|
I closed it, since a similar solution appeared in #2438 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic of
DefaultScopedContextProvider, by using two kinds ofScopedContext.Instanceimplementations:MapInstanceis a simple container for an immutable map and is the only implementation that can be set in theThreadLocal,KeyValueInstancerepresents a node of a linked list ofkey/valuepairs. It is used to record differences from aMapInstanceand is converted into aMapInstancein thewrapmethods.