Require requests >= 2.26.0 as part of install_requires when running on Python >= 3.6#1619
Merged
Kami merged 16 commits intoapache:trunkfrom Oct 26, 2021
Merged
Require requests >= 2.26.0 as part of install_requires when running on Python >= 3.6#1619Kami merged 16 commits intoapache:trunkfrom
Kami merged 16 commits intoapache:trunkfrom
Conversation
install_requires in setup.py to 2.26.0 when running under Python >= 3.6. This was done to avoid potential licensing issue with transitive dependency of the requests library (chardet). NOTE: Since requests 2.26.0 dropped support for Python 3.5 which we still stupport, requests >= 2.25.1 is required when running under Python 3.5. Thanks to Jarek Potiuk - @potiuk for reporting this issue. Resolves apache#1594.
things up. Also run it under Python 3.8 and Python 3.9.
Codecov Report
@@ Coverage Diff @@
## trunk #1619 +/- ##
==========================================
- Coverage 83.02% 83.02% -0.01%
==========================================
Files 394 394
Lines 85305 85309 +4
Branches 9073 9074 +1
==========================================
+ Hits 70827 70828 +1
- Misses 11392 11395 +3
Partials 3086 3086
Continue to review full report at Codecov.
|
8cf26d9 to
e614d59
Compare
installed from pip using all the supported versions.
e614d59 to
71f4f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve #1594 (at least partially).
Since we still support Python 3.5, we require older version of requests when running under Python 3.6 since the latest version of requests doesn't support Python 3.5 anymore.
In addition to that, I updated CI job to also run all the dist install checks there - I thought we already did that on CI, probably got lost when moving from Travis to Github Actions or similar.