KAFKA-12993: fix memory-mgmt.html formatting#361
Conversation
| <span class="kd">public</span> <span class="kt">void</span> <span class="nf">setConfig</span><span class="o">(</span><span class="kd">final</span> <span class="n">String</span> <span class="n">storeName</span><span class="o">,</span> <span class="kd">final</span> <span class="n">Options</span> <span class="n">options</span><span class="o">,</span> <span class="kd">final</span> <span class="n">Map</span><span class="o"><</span><span class="n">String</span><span class="o">,</span> <span class="n">Object</span><span class="o">></span> <span class="n">configs</span><span class="o">)</span> <span class="o">{</span> | ||
|
|
||
| <span class="n">BlockBasedTableConfig</span> <span class="n">tableConfig</span> <span class="o">=</span> <span class="k">(BlockBasedTableConfig)</span> <span class="n">options</span><span><span class="o">.</span><span class="na">tableFormatConfig</span><span class="o">();</span> | ||
| <span class="n">BlockBasedTableConfig</span> <span class="n">tableConfig</span> <span class="o">=</span> <span class="k">(BlockBasedTableConfig)</span> <span class="n">options</span><span class="o">.</span><span class="na">tableFormatConfig</span><span class="o">();</span> |
There was a problem hiding this comment.
fix 2: remove redundant span tag
| <span class="c1">// Cache and WriteBufferManager should not be closed here, as the same objects are shared by every store instance.</span> | ||
| <span class="o">}</span> | ||
| <span class="o">}</span> | ||
| </pre> |
There was a problem hiding this comment.
fix 1: add missing pre tag
| In addition to the recommended configs above, you may want to consider using partitioned index filters as described by the <a class="reference external" href="https://github.com/facebook/rocksdb/wiki/Partitioned-Index-Filters">RocksDB docs</a>. | ||
|
|
||
| </dl> | ||
| </sup> |
|
@ableegoldman , please take a look. Thanks. |
|
@showuon I think this has been already done in PR #10651. |
| <p> Each instance of RocksDB allocates off-heap memory for a block cache, index and filter blocks, and memtable (write buffer). Critical configs (for RocksDB version 4.1.0) include | ||
| <code class="docutils literal"><span class="pre">block_cache_size</span></code>, <code class="docutils literal"><span class="pre">write_buffer_size</span></code> and <code class="docutils literal"><span class="pre">max_write_buffer_number</span></code>. These can be specified through the | ||
| <code class="docutils literal"><span class="pre">rocksdb.config.setter</span></code> configuration.</li> | ||
| <code class="docutils literal"><span class="pre">rocksdb.config.setter</span></code> configuration.</li></p> |
|
@ableegoldman , I've checked, the line 165 for |
|
Gotcha, thanks for checking. Can you try setting up a local Apache server to test these changes (see instructions here)? |
|
Will do and let you know. Thanks. |
|
@ableegoldman , I've updated and confirmed the change can fix the formatting issue. |
@ableegoldman this is great to know. I was not aware of this before now. @showuon I will review it on Monday and share my feedback as well. I am looking to contribute documentation changes myself as well |
ableegoldman
left a comment
There was a problem hiding this comment.
This slipped past my radar, but it looks like we're good to merge here and close out the ticket. Thanks @showuon
We have updated the
memory-mgmt.htmlinkafkarepo in this PR: apache/kafka#10651.So, this pr, just simply fix the missing
preclosing tag issue.spantag