Skip to content

MINOR: Using primitive data types for loop index#9705

Merged
chia7712 merged 1 commit into
apache:trunkfrom
APaMio:MINOR-ImproveCodeSafety
Dec 9, 2020
Merged

MINOR: Using primitive data types for loop index#9705
chia7712 merged 1 commit into
apache:trunkfrom
APaMio:MINOR-ImproveCodeSafety

Conversation

@APaMio

@APaMio APaMio commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Change the loop index from Object into primitive data type

@chia7712

@APaMio APaMio changed the title HINOR: Using primitive data types for loop index MINOR: Using primitive data types for loop index Dec 7, 2020
@APaMio

APaMio commented Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

This request for change the loop index from wraps type to primitive type and some relative modify, those indices just used to pass as an argument not as an object, so I thought it`s not necessary to declare as an object.

These changes only affect the fragment program and will not have any impact on other parts.

I saw some error information in the Checks' Tab. I thought these problems aren't relative to my pull request. As below information.

Log tail
…1812 lines…

[2020-12-06T19:56:54.389Z]
[2020-12-06T19:56:54.389Z] org.apache.kafka.streams.scala.StreamToTableJoinScalaIntegrationTestImplicitSerdes > testShouldCountClicksPerRegion PASSED
[2020-12-06T19:56:55.344Z]
[2020-12-06T19:56:55.344Z] > Task :streams:test-utils:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-0100:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-0101:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-0102:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-0110:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-10:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-11:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-20:integrationTest
[2020-12-06T19:56:55.344Z] > Task :streams:upgrade-system-tests-21:integrationTest
[2020-12-06T19:56:56.300Z] > Task :streams:upgrade-system-tests-22:integrationTest
[2020-12-06T19:56:56.300Z] > Task :streams:upgrade-system-tests-23:integrationTest
[2020-12-06T19:56:56.300Z] > Task :streams:upgrade-system-tests-24:integrationTest
[2020-12-06T19:56:56.300Z] > Task :streams:upgrade-system-tests-25:integrationTest
[2020-12-06T19:56:56.300Z] > Task :streams:upgrade-system-tests-26:integrationTest
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] FAILURE: Build failed with an exception.
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] * What went wrong:
[2020-12-06T19:56:56.300Z] Execution failed for task ':connect:mirror:integrationTest'.
[2020-12-06T19:56:56.300Z] > Process 'Gradle Test Executor 53' finished with non-zero exit value 1
[2020-12-06T19:56:56.300Z] This problem might be caused by incorrect test process configuration.
[2020-12-06T19:56:56.300Z] Please refer to the test execution section in the User Manual at https://docs.gradle.org/6.7.1/userguide/java_testing.html#sec:test_execution
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] * Try:
[2020-12-06T19:56:56.300Z] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] * Get more help at https://help.gradle.org
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
[2020-12-06T19:56:56.300Z] Use '--warning-mode all' to show the individual deprecation warnings.
[2020-12-06T19:56:56.300Z] See https://docs.gradle.org/6.7.1/userguide/command_line_interface.html#sec:command_line_warnings
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] BUILD FAILED in 2h 4m 10s
[2020-12-06T19:56:56.300Z] 159 actionable tasks: 64 executed, 95 up-to-date
[2020-12-06T19:56:56.300Z]
[2020-12-06T19:56:56.300Z] See the profiling report at: file:///home/jenkins/workspace/Kafka_kafka-pr_PR-9705/build/reports/profile/profile-2020-12-06-17-52-47.html
[2020-12-06T19:56:56.300Z] A fine-grained performance profile is available: use the --scan option.
script returned exit code 1

@chia7712

chia7712 commented Dec 8, 2020

Copy link
Copy Markdown
Member

@APaMio Could you rebase code to include 8db3b1a?

Change the loop index from Object into primitive data type
@APaMio APaMio force-pushed the MINOR-ImproveCodeSafety branch from 4271d26 to 8738240 Compare December 8, 2020 21:22

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@APaMio Thanks for your patch. LGTM

@chia7712 chia7712 merged commit c557580 into apache:trunk Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants