KAFKA-10748: Add IP connection rate throttling metric#9685
Merged
Conversation
apovzner
reviewed
Dec 8, 2020
| @@ -1753,9 +1761,9 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics: Metrics) extend | |||
| * The average is out of all throttle times > 0, which is consistent with the bandwidth and request quota throttle | |||
Contributor
There was a problem hiding this comment.
need to update comment for this method, because the beginning of the comment says that throttle is due to hitting connection rate quota.
apovzner
approved these changes
Dec 8, 2020
apovzner
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the IP throttling metric as described in KIP-612.
Committer Checklist (excluded from commit message)