KAFKA-10677; Complete fetches in purgatory immediately after resigning#9639
Merged
Conversation
added 2 commits
November 22, 2020 22:29
Member
Author
|
ping @hachikuji to have a look. |
hachikuji
reviewed
Dec 9, 2020
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
@dengziming Thanks for the patch. Just had a couple minor comments on the test case.
hachikuji
approved these changes
Dec 9, 2020
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Note I pushed a trivial alignment fix in RaftClientTestContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
If the condition of fetch is satisfied,
BROKER_NOT_AVAILABLEorNOT_LEADER_OR_FOLLOWERis returned when the leader is shutting down. so we just returnBROKER_NOT_AVAILABLEwith a message.Summary of testing strategy
A simple unit test to verify fetches in purgatory is completed after resigning.
Committer Checklist (excluded from commit message)