KAFKA-9892: Producer state snapshot needs to be forced to disk#9621
Merged
Conversation
junrao
reviewed
Nov 19, 2020
Contributor
|
@bristy Thanks for the patch. I'd suggest changing to this: try {
fileChannel.write(buffer)
fileChannel.force(true)
} finally {
fileChannel.close()
}If you don't have time to get back to this, I can push a commit. |
hachikuji
approved these changes
Dec 9, 2020
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileChannel.close() does not guarantee modified buffer would be written on the file system. We are changing it with force() semantics to enforce file buffer and metadata written to filesystem ( FileChannel.force(true) updates buffer and metadata).
*Summary of testing strategy (including rationale)
I have run unittests after making the changes.