Skip to content

KAFKA-10599: Implement basic CLI tool for feature versioning system#9455

Merged
junrao merged 1 commit into
apache:2.7from
kowshik:kip584_FeatureCommand_2.7_cherrypick
Oct 20, 2020
Merged

KAFKA-10599: Implement basic CLI tool for feature versioning system#9455
junrao merged 1 commit into
apache:2.7from
kowshik:kip584_FeatureCommand_2.7_cherrypick

Conversation

@kowshik

@kowshik kowshik commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

[KIP-584]: Cherry pick PR #9409 implementing a basic CLI tool for feature versioning system, into AK 2.7 release branch.

@kowshik

kowshik commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

cc @abbccdda @junrao: This cherry-pick PR is ready for review.

@abbccdda

Copy link
Copy Markdown

retest this please

@kowshik

kowshik commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

@abbccdda I'm not sure whats going on, there is a maven error in the CI run. Would you be able to please trigger a retest ?

@junrao

junrao commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

This is probably due to #9453. Just merged that PR to 2.7.

@junrao

junrao commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

retest this please

@junrao

junrao commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

test this please

@junrao

junrao commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

ok to test

@junrao

junrao commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

@kowshik : Maybe you can rebase this PR to trigger another test.

…pache#9409)

This PR implements a basic CLI tool for feature versioning system. The KIP-584 write up has been updated to suit this PR. The following is implemented in this PR:

--describe:
Describe supported and finalized features.
Usage: $> ./bin/kafka-features.sh --bootstrap-server host1:port1, host2:port2 --describe [--from-controller] [--command-config <path_to_java_properties_file>]
Optionally, use the --from-controller option to get features from the controller.
--upgrade-all:
Upgrades all features known to the tool to their highest max version levels.
Usage: $> ./bin/kafka-features.sh --bootstrap-server host1:port1, host2:port2 --upgrade-all [--dry-run] [--command-config <path_to_java_properties_file>]
Optionally, use the --dry-run CLI option to preview the feature updates without actually applying them.
--downgrade-all:
Downgrades existing finalized features to the highest max version levels known to this tool.
Usage: $> ./bin/kafka-features.sh --bootstrap-server host1:port1, host2:port2 --downgrade-all [--dry-run] [--command-config <path_to_java_properties_file>].
Optionally, use the --dry-run CLI option to preview the feature updates without actually applying them.

Reviewers: Boyang Chen <boyang@confluent.io>, Jun Rao <junrao@gmail.com>
@kowshik kowshik force-pushed the kip584_FeatureCommand_2.7_cherrypick branch from a7b86ad to 2ac140b Compare October 20, 2020 02:48
@kowshik

kowshik commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

@junrao Good idea. I've done a rebase now on top of latest 2.7 branch.

@junrao junrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kowshik : Thanks for the PR. LGTM

@junrao junrao merged commit eb14539 into apache:2.7 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants