KAFKA-9091: Add a metric tracking the number of open connections with a given SSL cipher type#7588
Conversation
tombentley
left a comment
There was a problem hiding this comment.
LGTM, but a couple of question for my own benefit.
|
retest this please |
59387bc to
832a6f4
Compare
ijuma
left a comment
There was a problem hiding this comment.
A few more comments. Also, can we please add tests?
… a given SSL cipher type
5cd95b5 to
dea1270
Compare
24d02c5 to
423edcc
Compare
|
@cmccabe How far are you from merging this one? I'd like to reuse your |
ijuma
left a comment
There was a problem hiding this comment.
Thanks for adding the test and other updates. A few comments/questions below.
rajinisivaram
left a comment
There was a problem hiding this comment.
@cmccabe Thanks for the PR, looks good. Left a few minor comments. The KIP seems to suggest that the new metric is only on the broker (it shows listener name etc.), while I think we are adding the metric on both client-side and server-side. May be worth updating the KIP to reflect that.
rajinisivaram
left a comment
There was a problem hiding this comment.
@cmccabe Thanks for the updates, LGTM. Left a minor comment, but it should be ok to leave it as-is too.
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class CipherInformation { |
There was a problem hiding this comment.
Still not sure about the name since this already includes more than just cipher. But since it is an internal class, it should be ok to leave it as is for now.
No description provided.