KAFKA-19592: testGenerateAssignmentWithBootstrapServer uses wrong JSON format#20336
Merged
Conversation
FrankYang0529
left a comment
Member
There was a problem hiding this comment.
It looks like PartitionReassignmentState and VerifyAssignmentResult can be records. Could you update it? Thanks.
m1a2st
reviewed
Aug 11, 2025
frankvicky
reviewed
Aug 11, 2025
frankvicky
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch.
I have a minor comment for you to consider.
Comment on lines
+156
to
+161
| String topicsToMoveJson = "{\"topics\":\n\t[{\"topic\": \"foo\"}],\n\"version\":1\n}"; | ||
| var assignment = generateAssignment(admin, topicsToMoveJson, "1,2,3", false); | ||
| Map<TopicPartition, List<Integer>> proposedAssignments = assignment.getKey(); | ||
| String assignmentJson = String.format("{\"version\":1,\"partitions\":" + | ||
| "[{\"topic\":\"foo\",\"partition\":0,\"replicas\":%s,\"log_dirs\":[\"any\",\"any\",\"any\"]}" + | ||
| "]}", proposedAssignments.get(foo0)); |
Contributor
There was a problem hiding this comment.
It's not easy to read. Can we use the text block feature from Java 17?
For example:
String assignmentJson = String.format("""
{"version":1,"partitions":\
[{"topic":"foo","partition":0,"replicas":%s,"log_dirs":["any","any","any"]}\
]}""", proposedAssignments.get(foo0));
FrankYang0529
approved these changes
Aug 11, 2025
FrankYang0529
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the patch.
m1a2st
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR do following:
PartitionReassignmentStateandVerifyAssignmentResult.javabecome record
Reviewers: TengYao Chi frankvicky@apache.org, Ken Huang
s7133700@gmail.com, PoAn Yang payang@apache.org