MINOR: Improve RLMM doc#20306
Merged
Merged
Conversation
Change-Id: I187156ba38879701af3c3884ab9f7237ad97f79f
showuon
reviewed
Aug 7, 2025
showuon
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Could you follow this guide to generate the doc and have some screenshot for us to show how it will look like after this change?
Thank you.
Contributor
Author
|
@showuon Here are screenshots related to the changes: |
chia7712
approved these changes
Aug 8, 2025
chia7712
approved these changes
Aug 8, 2025
| <pre><code class="language-text"># Configs for admin, producer, and consumer clients | ||
| <rlmm.prefix>.remote.log.metadata.common.client.<kafka.property> = <value> | ||
|
|
||
| # Configs only for producer client |
Member
There was a problem hiding this comment.
@showuon Do you know why the admin does not have a config prefix like that?
Member
There was a problem hiding this comment.
No special reason behind it. I think it's just that most of the configs in admin is overlapping with producer/consumer. But maybe it'd be better we have a way to set configs to only admin client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve RLMM doc:
Reviewers: Luke Chen showuon@gmail.com, TengYao Chi kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com