Skip to content

MINOR: Modify TransactionsExpirationTest check so the test is less flaky#17831

Closed
jolshan wants to merge 1 commit into
apache:trunkfrom
jolshan:flakyTransactionsTest
Closed

MINOR: Modify TransactionsExpirationTest check so the test is less flaky#17831
jolshan wants to merge 1 commit into
apache:trunkfrom
jolshan:flakyTransactionsTest

Conversation

@jolshan

@jolshan jolshan commented Nov 15, 2024

Copy link
Copy Markdown
Member

With TV2 we bump epoch on each EndTxn call. This test sometimes would get the producer state before that bump and sometimes after. Given the test is really about checking the expiration of the producer id state and the state gets repopulated, the exact value of the epoch is not important. This should make the test less flaky

@github-actions github-actions Bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 15, 2024

@artemlivshits artemlivshits left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolshan

jolshan commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

Decided to merge #17822 instead.

@jolshan jolshan closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants