You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This patch updates getOrMaybeCreateClassicGroup to only throw GroupIdNotFoundException as we did for other internal methods. The callers are responsible for translating the error to the appropriate one depending on the context. There is only one case.
Committer Checklist (excluded from commit message)
This patch updates getOrMaybeCreateClassicGroup to only throw GroupIdNotFoundException as we did for other internal methods.
Pardon me, I fail to get the context. why getOrMaybeCreatePersistedShareGroup and getOrMaybeCreatePersistedConsumerGroup throw IllegalStateException rather than GroupIdNotFoundException?
This patch updates getOrMaybeCreateClassicGroup to only throw GroupIdNotFoundException as we did for other internal methods.
Pardon me, I fail to get the context. why getOrMaybeCreatePersistedShareGroup and getOrMaybeCreatePersistedConsumerGroup throw IllegalStateException rather than GroupIdNotFoundException?
getOrMaybeCreatePersistedShareGroup and getOrMaybeCreatePersistedConsumerGroup are only used in the replay methods. In this context, using an IllegalStateException makes sense because the state is indeed illegal if we replay a record and we don't have the required state in place. We could also use GroupIdNotFoundException in those two. It does not make a big difference in the end.
getOrMaybeCreateShareGroup and getOrMaybeCreateConsumerGroup are used in other paths and they both use GroupIdNotFoundException like getOrMaybeCreateClassicGroup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIP-848The Next Generation of the Consumer Rebalance Protocol
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AndrewJSchofield
left a comment
This patch updates
getOrMaybeCreateClassicGroupto only throwGroupIdNotFoundExceptionas we did for other internal methods. The callers are responsible for translating the error to the appropriate one depending on the context. There is only one case.Committer Checklist (excluded from commit message)