KAFKA-13785: [6/N][Emit final] Copy: Emit final for TimeWindowedKStreamImpl#12100
Merged
Conversation
Contributor
Author
|
The only differences between this copy PR and the original ones are 1) resolved conflicts, 2) incorporated latest comments. cc @mjsax |
vvcephei
approved these changes
May 3, 2022
vvcephei
left a comment
Contributor
There was a problem hiding this comment.
Thanks for finishing this up, @guozhangwang . It LGTM, modulo that failing test, which may be unrelated (I didn't check).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy PR of #11896, authored by @lihaosky
Committer Checklist (excluded from commit message)