MINOR: fix html generation syntax errors#12094
Merged
Merged
Conversation
Contributor
guozhangwang
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*More detailed description of your change,
The html document generation has some errors in it, specifically related to protocols. The two issues identified and resolved are:
</tbody>closing tags added<p>tag as a wrapper element for<table>elements. Changed the<p>tag to be a<div>.*Summary of testing strategy (including rationale)
Tested by running
./gradlew siteDocsTarand observing that the output was properly formed.Committer Checklist (excluded from commit message)