Skip to content

MINOR: Rename ZkVersion to PartitionEpoch#12071

Merged
dajac merged 3 commits into
apache:trunkfrom
dajac:KAFKA-13790-1
Apr 22, 2022
Merged

MINOR: Rename ZkVersion to PartitionEpoch#12071
dajac merged 3 commits into
apache:trunkfrom
dajac:KAFKA-13790-1

Conversation

@dajac

@dajac dajac commented Apr 20, 2022

Copy link
Copy Markdown
Member

This patch does some initial cleanups in the context of KAFKA-13790. Mainly, it renames ZkVersion field to PartitionEpoch in the LeaderAndIsrRequest, the LeaderAndIsr and the Partition.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac requested a review from hachikuji April 20, 2022 12:19
dengziming
dengziming reviewed Apr 20, 2022
View reviewed changes
Comment thread clients/src/main/resources/common/message/LeaderAndIsrRequest.json Outdated
@dajac dajac changed the title KAFKA-13790; ReplicaManager should be robust to all partition updates from kraft metadata log (1) MINOR: Rename ZkVersion to PartitionEpoch Apr 21, 2022
@hachikuji

hachikuji commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

cc @jsancio

hachikuji
hachikuji reviewed Apr 21, 2022
View reviewed changes

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good overall. A couple small comments.

Comment thread clients/src/main/resources/common/message/LeaderAndIsrRequest.json Outdated
Comment thread core/src/main/scala/kafka/cluster/Partition.scala Outdated
@dajac dajac requested a review from hachikuji April 21, 2022 18:40
@dajac

dajac commented Apr 21, 2022

Copy link
Copy Markdown
Member Author

Thanks @hachikuji. I have addressed your comments.

hachikuji
hachikuji reviewed Apr 22, 2022
View reviewed changes

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few nits.

Comment thread core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala Outdated
Comment thread core/src/test/scala/unit/kafka/utils/TestUtils.scala Outdated
Comment thread core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala Outdated
@dajac dajac requested a review from hachikuji April 22, 2022 06:43
@dajac

dajac commented Apr 22, 2022

Copy link
Copy Markdown
Member Author

Thanks @hachikuji. I have addressed your comments.

@dajac dajac mentioned this pull request Apr 22, 2022
Merged
3 tasks
hachikuji
hachikuji approved these changes Apr 22, 2022
View reviewed changes

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@dajac dajac merged commit 7c8c65f into apache:trunk Apr 22, 2022
@dajac dajac deleted the KAFKA-13790-1 branch April 22, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dengziming dengziming dengziming left review comments

@hachikuji hachikuji hachikuji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dajac @hachikuji @dengziming