MINOR: Fix display names for parameterized KRaft and ZK tests#11957
Merged
cmccabe merged 3 commits intoMar 28, 2022
Merged
Conversation
Contributor
|
Thanks for the PR, @skaundinya15 . This seems like a good readability improvement. Is it possible to use a constant here rather than repeating the literal string? If we had a constant, we could put it in TestInfoUtils, I suppose. |
e914428 to
01ed560
Compare
Contributor
Author
|
@cmccabe Thanks for the feedback, just pushed a new patch where there's a string in |
Contributor
|
retest this please |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds display names for KRaft and ZK tests. Without this, it becomes hard to understand in Jenkins test reports which test failed. With this addition, it becomes more clear which method in the test suite fails.