MINOR: Log member id of the leader when assignment are received#10817
Merged
Conversation
showuon
approved these changes
Jun 6, 2021
showuon
left a comment
Member
There was a problem hiding this comment.
LGTM! Left a minor comment. You can decide if you want to update it or not. Thanks.
| // if this is the leader, then we can attempt to persist state and transition to stable | ||
| if (group.isLeader(memberId)) { | ||
| info(s"Assignment received from leader for group ${group.groupId} for generation ${group.generationId}. " + | ||
| info(s"Assignment received from leader $memberId for group ${group.groupId} for generation ${group.generationId}. " + |
Member
There was a problem hiding this comment.
nit: Should we wrap the variable with single/double quote to make it clear? Ex:
info(s"Assignment received from leader '$memberId' for group '${group.groupId}' for generation '${group.generationId'}.
Member
Author
There was a problem hiding this comment.
@showuon At the moment, none of the other log in the group coordinator does this so it feel a bit weird to do it only in this case. I prefer keeping it as it is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)