MINOR: Style fixes to KafkaRaftClient#10809
Merged
Merged
Conversation
showuon
approved these changes
Jun 3, 2021
showuon
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for the PR. Might need to merge trunk and trigger the jenkins build again since there are jdk 8 + scala 2.12 and jdk11 + scala 2.13 failed with:
Process 'Gradle Test Executor 127' finished with non-zero exit value 1
Member
|
@abbccdda Committer approval is required for PRs to be merged. I don't see that here. |
Author
|
@ijuma That's a good call, should I revert it? It was just a styling change PR. |
Member
|
You don't have to revert it, but can you please get a committer approval? |
Member
|
@ijuma we should be able to configure the repo to require an approval from a committer for |
Member
|
@mumrah We haven't and it would be good to do. |
Member
|
@ijuma i'll send something out on the devs list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title suggested, made some style fixes to the class
KafkaRaftClientCommitter Checklist (excluded from commit message)