Skip to content

MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface#10801

Merged
dajac merged 1 commit into
apache:trunkfrom
KahnCheny:branch-apache-remove-public
Jun 2, 2021
Merged

MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface#10801
dajac merged 1 commit into
apache:trunkfrom
KahnCheny:branch-apache-remove-public

Conversation

@KahnCheny

@KahnCheny KahnCheny commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@KahnCheny

Copy link
Copy Markdown
Contributor Author

@showuon Could you code review again?

@showuon showuon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KahnCheny

Copy link
Copy Markdown
Contributor Author

Thanks

@showuon

showuon commented Jun 2, 2021

Copy link
Copy Markdown
Member

@tombentley @chia7712 , could you help review this PR? I've reviewed and looks good. Need your 2nd review. Thank you.

Failed tests are flaky tests.

    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
    Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()

@dajac dajac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@dajac dajac merged commit 1a7ad70 into apache:trunk Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants