KAFKA-12709; Add Admin API for ListTransactions#10616
Merged
Merged
Conversation
dajac
reviewed
Apr 30, 2021
dajac
left a comment
Member
There was a problem hiding this comment.
@hachikuji Thanks for the PR. I just made a first pass on it and I left a few minor comments. Overall, the approach seems reasonable to me.
dajac
approved these changes
May 25, 2021
dajac
left a comment
Member
There was a problem hiding this comment.
@hachikuji The PR LGTM, thanks. I have left few minor nits about the error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
Adminsupport for thelistTransactionsAPI, which was added by KIP-664. Similar tolistConsumerGroups, the newlistTransactionsAPI is intended to be sent to all brokers. This did not fit very well with the newAdminApiDriverthat was used for the other KIP-664 APIs, so I had to refactor a bit. The way I ultimately handled it is to treat the brokerId as the key that needs to be mapped. Unlike with the other cases, the set of brokerIds is not known ahead of time and has to be discovered through aMetadatalookup (just as withlistConsumerGroups). Because the future associated withListTransactionsResultis more complex, I ended up externalizing future completion in a newAdminApiFutureobject which is passed toAdminApiDriverduring construction.One minor change that is also worth calling out is the removal of
AdminApiHandler.Keys. This was previously used to indicate the sets of statically and dynamically mapped keys. Instead, I now handle this with a newStaticBrokerStrategy. The static scope is indicated by returning anApiRequestScopeobject which has a specific destination broker set.Committer Checklist (excluded from commit message)