MINOR: cleanTest ought to remove output of unitTest task and integrat…#10585
Merged
Conversation
Member
Author
|
BTW, this patch fixes the commands in readme (https://github.com/apache/kafka/blob/trunk/README.md#force-re-running-tests-without-code-change) |
ijuma
reviewed
May 16, 2021
ijuma
approved these changes
May 29, 2021
ijuma
left a comment
Member
There was a problem hiding this comment.
LGTM with one suggestion below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command used by our private CI is
./gradlew cleanTest xxx:test. It does not re-run test when we useunitTestandintegrationTestto replacetest. The root cause is that we don't offer test output (unitTestandintegrationTest) tocleanTesttask and so it does not delete related test output.Committer Checklist (excluded from commit message)