Skip to content

[INLONG-3473][GitHub][K8s] Add support for chart testing#3676

Merged
dockerzhang merged 23 commits intoapache:masterfrom
shink:INLONG-3473
May 8, 2022
Merged

[INLONG-3473][GitHub][K8s] Add support for chart testing#3676
dockerzhang merged 23 commits intoapache:masterfrom
shink:INLONG-3473

Conversation

@shink
Copy link
Copy Markdown
Member

@shink shink commented Apr 13, 2022

Fixes: #3473

Motivation

Use helm/chart-testing-action to test helm charts on GitHub Actions.
When the helm charts changes, they can be tested automatically.

Modifications

  • Add chart test workflow

Documentation

Have updated documentation, please check out shink@45c705f

@shink
Copy link
Copy Markdown
Member Author

shink commented Apr 13, 2022

@dockerzhang dockerzhang marked this pull request as draft April 13, 2022 12:49
@shink shink marked this pull request as ready for review April 18, 2022 08:42
@shink shink requested a review from dockerzhang April 18, 2022 08:43
@shink shink marked this pull request as draft April 18, 2022 08:52
@shink shink marked this pull request as ready for review April 19, 2022 03:23
@shink
Copy link
Copy Markdown
Member Author

shink commented Apr 19, 2022

@dockerzhang
Copy link
Copy Markdown
Contributor

@shink
1, please rebase after #4121 merged.
2, choose k8s version v1.21+ to avoid policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+ warnning.

@github-actions github-actions bot added the github label May 8, 2022
@shink
Copy link
Copy Markdown
Member Author

shink commented May 8, 2022

2, choose k8s version v1.21+ to avoid policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+ warnning.

@dockerzhang
We can compate with different versions of Kubernetes in Helm Chart1.
For example:

Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget

Then we can check apiVersion in the Chart.

{{- if .Capabilities.APIVersions.Has "policy/v1" }}
apiVersion: policy/v1
{{- else }}
apiVersion: policy/v1beta1
{{- end }}

Footnotes

  1. https://os.51cto.com/article/689655.html

@dockerzhang dockerzhang merged commit ad5e873 into apache:master May 8, 2022
@healchow healchow changed the title [INLONG-3473][CI] Add support for chart testing [INLONG-3473][GitHub][K8s] Add support for chart testing Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service/ci Automatically confirm that the code is error-free service/k8s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][GitHub][K8s] Add support for helm chart testing

3 participants