Skip to content

Be sure to close thread pool when not in use#3207

Closed
scxwhite wants to merge 4 commits intoapache:masterfrom
scxwhite:master
Closed

Be sure to close thread pool when not in use#3207
scxwhite wants to merge 4 commits intoapache:masterfrom
scxwhite:master

Conversation

@scxwhite
Copy link
Copy Markdown
Contributor

@scxwhite scxwhite commented Jan 11, 2019

What is the purpose of the change

Be sure to close thread pool when not in use

Brief changelog

Memory leak

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

import java.util.concurrent.RejectedExecutionException;
import java.util.concurrent.Semaphore;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.*;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use import *

@carryxyh
Copy link
Copy Markdown
Member

Why u change all of this class?
Pls revert it. otherwise, LGTM

@scxwhite
Copy link
Copy Markdown
Contributor Author

Why u change all of this class?
Pls revert it. otherwise, LGTM

oh my god ! i use github deal conflict,i revert it.

@scxwhite
Copy link
Copy Markdown
Contributor Author

Why u change all of this class?
Pls revert it. otherwise, LGTM

@scxwhite scxwhite closed this Jan 16, 2019
@scxwhite scxwhite reopened this Jan 16, 2019
@scxwhite
Copy link
Copy Markdown
Contributor Author

I think I should deal with it. It still shows so much line after revert. I will submit a new PR

@scxwhite scxwhite closed this Jan 16, 2019
@scxwhite scxwhite deleted the master branch January 16, 2019 12:19
@scxwhite
Copy link
Copy Markdown
Contributor Author

Why u change all of this class?
Pls revert it. otherwise, LGTM

I am so sorry. No experience to submit pr.please see new pr.#3255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants