Skip to content

fix(metadata): export iceberg schema in snapshots table #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liurenjie1024 merged 5 commits into from
Mar 31, 2025
Merged

fix(metadata): export iceberg schema in snapshots table #1135

liurenjie1024 merged 5 commits into from
Mar 31, 2025

Conversation

@xxchan
Copy link
Member

@xxchan xxchan commented Mar 25, 2025

same as #871

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Are these changes tested?

xxchan added 2 commits March 25, 2025 23:07
@xxchan
fix(metadata): export iceberg schema in snapshots table
b66b541 
same as apache#871

Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan
align impl with java
5e93c3c 
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
xxchan commented Mar 25, 2025
View reviewed changes
crates/iceberg/src/inspect/snapshots.rs
Comment on lines 44 to 51
let fields = vec![
NestedField::required(1, "committed_at", Type::Primitive(PrimitiveType::Timestamp)),
NestedField::required(2, "snapshot_id", Type::Primitive(PrimitiveType::Long)),
NestedField::optional(3, "parent_id", Type::Primitive(PrimitiveType::Long)),
NestedField::required(4, "operation", Type::Primitive(PrimitiveType::String)),
NestedField::required(5, "manifest_list", Type::Primitive(PrimitiveType::String)),
NestedField::required(
6,
Copy link
Member Author

@xxchan xxchan Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema is changed to be more aligned with Java https://github.com/apache/iceberg/blob/03ff41c189c7420992be0e4a4ddc63f005e2e0d5/core/src/main/java/org/apache/iceberg/SnapshotsTable.java#L30-L40

Previously it aligns with Python.

@xxchan
bump arrow
b92acf7 
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
xxchan commented Mar 25, 2025
View reviewed changes
Cargo.toml
Comment on lines +45 to +52
arrow-arith = { version = "54.2.0" }
arrow-array = { version = "54.2.0" }
arrow-buffer = { version = "54.2.0" }
arrow-cast = { version = "54.2.0" }
arrow-ord = { version = "54.2.0" }
arrow-schema = { version = "54.2.0" }
arrow-select = { version = "54.2.0" }
arrow-string = { version = "54.2.0" }
Copy link
Member Author

@xxchan xxchan Mar 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump arrow crates, as with_keys_field is introduced in 54.2

(caught by MSRV check
image

xxchan added 2 commits March 28, 2025 17:06
@xxchan
Merge branch 'main' into xxchan/coastal-lynx
412ab95
@xxchan
fix
4cf398f 
Signed-off-by: xxchan <xxchan22f@gmail.com>
liurenjie1024
liurenjie1024 approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xxchan for this pr, LGTM!

@liurenjie1024 liurenjie1024 merged commit 5cdd6eb into apache:main Mar 31, 2025
18 checks passed
@xxchan xxchan mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xxchan @liurenjie1024