Add Reproduction Test Case for Scan Panic on Schema with map<string, list<string>>#736
Closed
alexandre-normand wants to merge 2 commits intoapache:mainfrom
Closed
Add Reproduction Test Case for Scan Panic on Schema with map<string, list<string>>#736alexandre-normand wants to merge 2 commits intoapache:mainfrom
alexandre-normand wants to merge 2 commits intoapache:mainfrom
Conversation
449eae0 to
2606c10
Compare
Member
|
Superceded and fixed by #748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test (not actually meant for merging) exercises a path that we found triggered scanning/reading to panic. The test case is meant to make for the simplest reproduction: it includes a schema with a single column called
tagswhich is a nullable map of string to a list of strings (i.e.map<string, list<string>>).The issue is that doing a scan on a table with such a schema (where it's possible for some rows to have an empty
tagsfield value) panics.The runtime panic looked like this:
Which is the same as this test: