fix(table): Handle nullable struct with Required Field#408
Merged
zeroshade merged 7 commits intoapache:mainfrom Apr 30, 2025
Merged
fix(table): Handle nullable struct with Required Field#408zeroshade merged 7 commits intoapache:mainfrom
zeroshade merged 7 commits intoapache:mainfrom
Conversation
Member
Author
|
@EthanBlackburn please take a look and try this out when you get a chance. Thanks! |
fe32e79 to
1316426
Compare
|
@zeroshade it works! 🥳 |
pdelewski
reviewed
Apr 29, 2025
pdelewski
reviewed
Apr 29, 2025
pdelewski
reviewed
Apr 30, 2025
pdelewski
approved these changes
Apr 30, 2025
Fokko
reviewed
Apr 30, 2025
table/arrow_utils.go
Outdated
| } | ||
| } | ||
|
|
||
| func ArrowSchemaToIcebergWithoutIDs(sc *arrow.Schema, downcastNsTimestamp bool) (*iceberg.Schema, error) { |
Contributor
There was a problem hiding this comment.
I think this name is confusing since we add fresh-IDs?
Contributor
There was a problem hiding this comment.
What about:
Suggested change
| func ArrowSchemaToIcebergWithoutIDs(sc *arrow.Schema, downcastNsTimestamp bool) (*iceberg.Schema, error) { | |
| func ArrowSchemaToIcebergWithFreshIDs(sc *arrow.Schema, downcastNsTimestamp bool) (*iceberg.Schema, error) { |
Open for other suggestions
Contributor
There was a problem hiding this comment.
What about moving this to testing?
Member
Author
There was a problem hiding this comment.
talked with Fokko separately and we decided we'll keep this in for now (albeit renamed). and remove/rework it in the future if necessary.
Fokko
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #398
Have
toRequestedSchemause the newNewStructArrayWithFieldsAndNullsfunction to correctly propagate null info and handle required fields within a nullable struct.