Core: Allow deleting old partition spec columns in V1 #7398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
reviewed
Apr 21, 2023
|
|
||
| table.updateSchema().deleteColumn("data").commit(); | ||
|
|
||
| // This would throw a NPE |
Contributor
There was a problem hiding this comment.
is this comment still apply?
Contributor
Author
There was a problem hiding this comment.
I agree that it is better to remove it, thanks!
dramaticlly
approved these changes
Apr 21, 2023
Contributor
dramaticlly
left a comment
There was a problem hiding this comment.
thank you @Fokko for fixing this!
hililiwei
reviewed
Apr 28, 2023
Contributor
hililiwei
left a comment
There was a problem hiding this comment.
LGTM, just one format comment.
| // This only happens in V1 tables where the reference is still around as a void transform | ||
| fieldId = field.sourceId(); | ||
| } | ||
| specBuilder.addField(field.transform().toString(), fieldId, field.fieldId(), field.name()); |
nastra
reviewed
May 2, 2023
| @Test | ||
| public void testDeletingPartitionField() { | ||
| TestTables.TestTable table = | ||
| TestTables.create(tableDir, "test", SCHEMA, BY_DATA_SPEC, V1_FORMAT_VERSION); |
Contributor
There was a problem hiding this comment.
should we maybe also add a test that does the same with V2_FORMAT_VERSION?
jackye1995
approved these changes
May 8, 2023
Contributor
jackye1995
left a comment
There was a problem hiding this comment.
looks good to me. I see Eduard has a comment about testing in v2, which I am not sure if is worth it, up to you!
rdblue
approved these changes
May 16, 2023
Contributor
|
Thanks for fixing this, @Fokko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7386