Update doc to state that day partition transform produces data type#447
Merged
rdblue merged 2 commits intoapache:masterfrom Sep 13, 2019
Merged
Update doc to state that day partition transform produces data type#447rdblue merged 2 commits intoapache:masterfrom
rdblue merged 2 commits intoapache:masterfrom
Conversation
rdblue
reviewed
Sep 4, 2019
site/docs/spec.md
Outdated
| | **`year`** | Extract a date or timestamp year, as years from 1970 | `date`, `timestamp(tz)` | `int` | | ||
| | **`month`** | Extract a date or timestamp month, as months from 1970-01-01 | `date`, `timestamp(tz)` | `int` | | ||
| | **`day`** | Extract a date or timestamp day, as days from 1970-01-01 | `date`, `timestamp(tz)` | `int` | | ||
| | **`day`** | Extract a date or timestamp day, as date | `date`, `timestamp(tz)` | `date` | |
Contributor
There was a problem hiding this comment.
This should change the type but not description.
Contributor
Author
There was a problem hiding this comment.
@rdblue Comment addressed, Only "Return type" is changed. Please review at your most convenience, thanks!
Contributor
Author
There was a problem hiding this comment.
@rdblue Would you please help to review this change at your most convenience?
Contributor
Author
There was a problem hiding this comment.
Hi @rdblue Would you please help to review the change at your most convenience ? The comment addressed.
… addendum to address review comments
This was referenced Sep 5, 2022
This was referenced Sep 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix the doc for #279, to reflect the change made by #424