Spark: Disable min/max aggregation push down for string under any mode#16320
Merged
huaxingao merged 1 commit intoMay 13, 2026
Merged
Conversation
Contributor
Author
|
Hi @huaxingao, could you take a look at this fix when you have a chance? Thanks a lot! |
huaxingao
approved these changes
May 13, 2026
huaxingao
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the fix.
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics mode recorded in an Iceberg table reflects only the current state. That is to say, the mode may have been changed in the past, and when data was actually written earlier, the statistics were processed according to the metrics mode at that time. For example, the metrics mode might have been
truncate(5)when the data was written, and later changed toall. In such a case, deciding thatmin/maxaggregation on string columns can be pushed down based on the current metrics mode may lead to incorrect results. Refer to the test case in this PR for details.