Skip to content

TLS setup harmonization in the classic and async connection operators #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ok2c merged 4 commits into from
Jan 26, 2024
Merged

TLS setup harmonization in the classic and async connection operators #540

ok2c merged 4 commits into from
Jan 26, 2024

Conversation

@ok2c
Copy link
Member

@ok2c ok2c commented Jan 22, 2024 •
edited
Loading

  • Deprecation of ConnectionSocketFactory / LayeredConnectionSocketFactory APIs in favor of TlsSocketStrategy consistent with TlsStrategy used by the async APIs.
  • Deprecation of PlainConnectionSocketFactory without a direct replacement.
  • Deprecation of SSLConnectionSocketFactory in favor of DefaultClientTlsStrategy that can be used with classic and async transports

@ok2c ok2c requested a review from arturobernalg January 22, 2024 11:37
@ok2c
Copy link
Member Author

ok2c commented Jan 22, 2024

@arturobernalg Please take a look.

@ok2c ok2c mentioned this pull request Jan 22, 2024
Merged
@ok2c ok2c force-pushed the tls_setup_harmonization branch from d6f50a6 to 0d6e57a Compare January 22, 2024 11:45
@ok2c ok2c force-pushed the tls_setup_harmonization branch from 0d6e57a to fd2961a Compare January 22, 2024 15:52
@ok2c
Copy link
Member Author

ok2c commented Jan 26, 2024

If I hear no objections I will merge this PR in the coming days.

arturobernalg
arturobernalg approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c LGTM

@ok2c ok2c merged commit 9d225a6 into apache:master Jan 26, 2024
@ok2c ok2c deleted the tls_setup_harmonization branch January 26, 2024 09:19
@strangelookingnerd strangelookingnerd mentioned this pull request Oct 28, 2024
Closed
@basil
Copy link

basil commented Oct 28, 2024

@ok2c Causes HTTPCLIENT-2348.

@basil basil mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturobernalg arturobernalg arturobernalg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ok2c @basil @arturobernalg