Fix async builder fluent typing#1560
Merged
Merged
Conversation
Made-with: Cursor
skrawcz
approved these changes
May 3, 2026
skrawcz
left a comment
Contributor
There was a problem hiding this comment.
Thanks! LGTM — clean use of Self for the fluent builder pattern.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing_extensions.Selffor fluentdriver.Buildermethods that returnself.async_driver.Builder.build()as returningAsyncDriverwhen awaited.async_driver.Builder().with_modules(...).build()instead of falling back to the synchronousdriver.Builder.build()type.Fixes #1452
Test plan
python -m ruff check hamilton/driver.py hamilton/async_driver.pygit diff --checkpython -m pytest tests/test_async_driver.py -k Buildercould not run locally becausetyping_inspectis not installed in this environment.pyrightis not installed locally, so I could not run the original reporter's checker here.