Skip to content

Fix resolve docs parameterization example#1559

Merged
skrawcz merged 1 commit into
apache:mainfrom
Abdeltoto:docs-fix-resolve-parameterize-example
May 3, 2026
Merged

Fix resolve docs parameterization example#1559
skrawcz merged 1 commit into
apache:mainfrom
Abdeltoto:docs-fix-resolve-parameterize-example

Conversation

@Abdeltoto

Copy link
Copy Markdown
Contributor

Summary

  • Fix the @resolve reference docs example to use @parameterize_sources instead of @parameterize_values.
  • The example maps function parameters to upstream source nodes, which matches parameterize_sources semantics and the later dynamic @resolve example.

Fixes #1384

Test plan

  • python -m ruff check hamilton/function_modifiers/delayed.py
  • git diff --check

@skrawcz skrawcz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch on the docs example.

@skrawcz skrawcz merged commit b3a1ec7 into apache:main May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for @resolve has broken example

2 participants