[#990] feat(UI): Add create catalog in webUI#991
Conversation
Code Coverage Report
|
There was a problem hiding this comment.
It signifies the right part section, and it can be altered to be named TableContent.
| const { propItems, ...mainData } = data | ||
|
|
||
| const properties = innerProps.reduce((acc, item) => { | ||
| acc[item.key] = item.value |
There was a problem hiding this comment.
Is there a better variable name than acc?
There was a problem hiding this comment.
The full name is accumulator, but it's too long, so we just call it acc.
| error={Boolean(errors.provider)} | ||
| labelId='select-catalog-provider' | ||
| > | ||
| <MenuItem value={'hive'}>hive</MenuItem> |
There was a problem hiding this comment.
I think we needs add another provider list in here, like jdbc-mysql, jdbc-postgresql, and iceberg.
@FANNG1 , @Clearvive , Please help double check these names if correct?
There was a problem hiding this comment.
lakehouse-iceberg not iceberg
There was a problem hiding this comment.
I think it can be changed to the following
<MenuItem value={'lakehouse-iceberg'}>iceberg</MenuItem>
<MenuItem value={'jdbc-mysql'}>mysql</MenuItem>
<MenuItem value={'jdbc-postgresql'}>postgresql</MenuItem>
There was a problem hiding this comment.
Got it, I will incorporate these values.
|
|
||
| const [innerProps, setInnerProps] = useState([ | ||
| { | ||
| key: 'metastore.uris', |
There was a problem hiding this comment.
"metastore.uris" is the required property for hive catalog. And for different catalogs, they have different required properties, you can check with @mchades to get all the required properties for different catalogs.
There was a problem hiding this comment.
There was a problem hiding this comment.
iceberg--catalog-backend--hive:
iceberg--catalog-backend--jdbc:
66b739a to
8e6cf94
Compare
What changes were proposed in this pull request?
Create a catalog with actual data in the web UI.
Why are the changes needed?
Fix: #990
Does this PR introduce any user-facing change?
No
How was this patch tested?
No