[#747][#751][#752] feat(UI): add catalogs, schemas, tables pages in web#933
[#747][#751][#752] feat(UI): add catalogs, schemas, tables pages in web#933xunliu merged 2 commits intoapache:mainfrom
Conversation
Code Coverage Report
|
| ) | ||
| ) | ||
|
|
||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Does this comment need to be removed?
There was a problem hiding this comment.
Does this comment need to be removed?
No, this comment is used for eslint.
| const serialized = args[1] | ||
| if (cache.inserted[serialized.name] === undefined) { | ||
| inserted.push({ name: serialized.name, isGlobal: !selector }) | ||
| inserted.push({ name: serialized.name, global: !args[0] }) |
There was a problem hiding this comment.
All use of temporary variables? like this
const selector = args[0]
const serialized = args[1]
There was a problem hiding this comment.
All use of temporary variables? like this
const selector = args[0] const serialized = args[1]
The purpose of this JS file is to resolve the styles issue with Next.js being a default server-side rendering (SSR) engine.
args represents the unknown parameter list passed to the cache.insert method. It is only used for checking and will not be modified. Therefore, there is no need to declare the variable or constant again.
| import { getSchemasApi, getSchemaDetailsApi } from '@/lib/api/schemas' | ||
| import { getTablesApi, getTableDetailsApi } from '@/lib/api/tables' | ||
|
|
||
| export const fetchMetalakes = createAsyncThunk('appMetalakes/fetchMetalakes', async (params, { getState }) => { |
There was a problem hiding this comment.
Which means is this appMetalakes value name? app? api?
There was a problem hiding this comment.
Which means is this
appMetalakesvalue name?app?api?
appMetalakes is used in react-redux, its for managing states for differentiation, it be like namespace.
What changes were proposed in this pull request?
Added pages for catalogs, schemas, and tables.
Because the framework itself does not support dynamic values in client-side rendering mode, so it is done in the same component in the form of parameters.
Catalogs:
Schemas:
Tables:
Why are the changes needed?
Fix: #747
Fix: #751
Fix: #752
Does this PR introduce any user-facing change?
No
How was this patch tested?
No