[#897] fix: Unify parameter name of fieldName and fieldNames#932
Merged
jerryshao merged 1 commit intoapache:mainfrom Dec 4, 2023
Merged
[#897] fix: Unify parameter name of fieldName and fieldNames#932jerryshao merged 1 commit intoapache:mainfrom
jerryshao merged 1 commit intoapache:mainfrom
Conversation
Code Coverage Report
Files
|
jerryshao
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If this variable ends up pointing to only one field, it should be named
fieldName. Therefore, this PR changes all the field parameter name, which point to only one field, fromfieldNamestofieldNameeven though it's of type string arrayWhy are the changes needed?
We have many places that use either "fieldName" or "fieldNames", this will cause confusion
Fix: #897
Does this PR introduce any user-facing change?
yes, If it is a single field, the user should use
fieldName()methodHow was this patch tested?
existing UTs