Skip to content

[#894] feat(hive): The updateColumnNullability in the Hive catalog clearly failed#886

Merged
jerryshao merged 1 commit intoapache:mainfrom
mchades:hive-change-null
Nov 30, 2023
Merged

[#894] feat(hive): The updateColumnNullability in the Hive catalog clearly failed#886
jerryshao merged 1 commit intoapache:mainfrom
mchades:hive-change-null

Conversation

@mchades
Copy link
Contributor

@mchades mchades commented Nov 30, 2023

What changes were proposed in this pull request?

Add clear error message for updateColumnNullability in the Hive catalog

Why are the changes needed?

Since Hive does not support change column nullability, we should offer more clearly message for user.

Fix: #894

Does this PR introduce any user-facing change?

no

How was this patch tested?

UT added

@github-actions
Copy link

github-actions bot commented Nov 30, 2023

Code Coverage Report

Overall Project 66.19% 🟢
Files changed 100% 🟢

Module Coverage
catalog-hive 69.98% 🟢
Files
Module File Coverage
catalog-hive HiveCatalogOperations.java 72.81% 🟢

@mchades mchades changed the title [#767] feat(hive): The updateColumnNullability in the Hive catalog clearly failed [#894] feat(hive): The updateColumnNullability in the Hive catalog clearly failed Nov 30, 2023
@mchades mchades self-assigned this Nov 30, 2023
@mchades mchades marked this pull request as ready for review November 30, 2023 11:35
@jerryshao jerryshao merged commit 5f1f478 into apache:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] Hive catalog should fail change column nullability with clear message

2 participants