[#890] feat(common): Add JSON serde of UpdateColumnNullability#883
Merged
jerryshao merged 2 commits intoapache:mainfrom Nov 30, 2023
Merged
[#890] feat(common): Add JSON serde of UpdateColumnNullability#883jerryshao merged 2 commits intoapache:mainfrom
UpdateColumnNullability#883jerryshao merged 2 commits intoapache:mainfrom
Conversation
6 tasks
Code Coverage Report
Files
|
UpdateColumnNullabilityUpdateColumnNullability
5b59bbe to
ceb1325
Compare
jerryshao
reviewed
Nov 30, 2023
|
|
||
| @Getter | ||
| @JsonProperty("newNullable") | ||
| private final boolean newNullable; |
Contributor
There was a problem hiding this comment.
I would suggest to use "nullable" instead of "newNullable", which seems a little weird.
qqqttt123
reviewed
Nov 30, 2023
|
|
||
| @Getter | ||
| @JsonProperty("fieldName") | ||
| private final String[] fieldName; |
Contributor
There was a problem hiding this comment.
fieldName -> fieldNames?
Contributor
There was a problem hiding this comment.
We have many places which uses either "fieldName" or "fieldNames", I think we should unify them somehow. @mchades can you please create an issue to track this issue>
jerryshao
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add JSON serde of
UpdateColumnNullabilityWhy are the changes needed?
Fix: #890
Does this PR introduce any user-facing change?
no, only add JSON serde, client-side not implemented yet
How was this patch tested?
UTs added