Skip to content

[#983] feat(OpenAPI): add lint for OpenAPI#1012

Merged
jerryshao merged 2 commits intoapache:mainfrom
mchades:issue-983
Dec 8, 2023
Merged

[#983] feat(OpenAPI): add lint for OpenAPI#1012
jerryshao merged 2 commits intoapache:mainfrom
mchades:issue-983

Conversation

@mchades
Copy link
Contributor

@mchades mchades commented Dec 7, 2023

What changes were proposed in this pull request?

  • move node env to root project for reuse
  • use redocly/cli@1.5.0 to lint the OAS doc

Why are the changes needed?

ensure the OAP is correct

Fix: #983

Does this PR introduce any user-facing change?

no

How was this patch tested?

project build successfully

@mchades mchades self-assigned this Dec 7, 2023
@mchades
Copy link
Contributor Author

mchades commented Dec 7, 2023

This feature will not work until #1010 is merged, as it needs to validate file /docs/open-api/openapi.yaml

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

Code Coverage Report

Overall Project 65.7% 🟢

There is no coverage information present for the Files changed

@mchades
Copy link
Contributor Author

mchades commented Dec 8, 2023

This PR is ready now, please help to review it, thanks! @jerryshao @xunliu
image

@jerryshao jerryshao closed this Dec 8, 2023
@jerryshao jerryshao reopened this Dec 8, 2023
@jerryshao jerryshao merged commit 28dfefc into apache:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] check code style for OAS

2 participants