[GLUTEN-7028][CH][Part-12] Add Local SortExec for Partition Write in one pipeline mode#8237
Merged
baibaichen merged 6 commits intoapache:mainfrom Dec 17, 2024
Merged
Conversation
11 tasks
|
Run Gluten Clickhouse CI on x86 |
9efdeaf to
41e669b
Compare
|
Run Gluten Clickhouse CI on x86 |
41e669b to
d9b870a
Compare
|
Run Gluten Clickhouse CI on x86 |
…nd PlanSquashingTransform
…riteTaskStatsTracker: Expected x files, but only saw 0."
…n spark 35 for GlutenClickHouseMergeTreeWriteSuite
d9b870a to
633eee9
Compare
|
Run Gluten Clickhouse CI on x86 |
zzcclp
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since Clickhouse backend doesn't add local sort by itself, this is differnet with velox backend. This PR and Local
SortExecbased onSparkPlaninstead ofLogicalPlanfor Delta Write and removeRemoveNativeWriteFilesSortAndProjectfor datasource v1 write.WriteReldoesn't including partition column order issue by adding such information in write_optimization.protoApplySquashingTransformandPlanSquashingTransformfrom pipeline and addingSquashinginSparkMergeTreeSink.How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)