Skip to content

[GLUTEN-8080][CH]Support function transform_keys/transform_values#8085

Merged
taiyang-li merged 5 commits intoapache:mainfrom
bigo-sg:gluten_8080
Dec 2, 2024
Merged

[GLUTEN-8080][CH]Support function transform_keys/transform_values#8085
taiyang-li merged 5 commits intoapache:mainfrom
bigo-sg:gluten_8080

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li commented Nov 28, 2024 •
edited
Loading

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #8080 #8081)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Nov 28, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 28, 2024

#8080

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 28, 2024

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 29, 2024

Run Gluten Clickhouse CI on x86

@github-actions github-actions bot removed the VELOX label Nov 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 29, 2024

Run Gluten Clickhouse CI on x86

@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Nov 29, 2024

The four exlucded tests are added because of exception checkings in spark-ut, which is hard to implement in C++.

.exclude("transform keys function - primitive data types")
.exclude("transform keys function - Invalid lambda functions and exceptions")
.exclude("transform values function - test primitive data types")
.exclude("transform values function - test empty")

@taiyang-li taiyang-li requested review from zzcclp and removed request for zzcclp November 29, 2024 06:27
@taiyang-li taiyang-li removed the request for review from marin-ma November 29, 2024 09:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 29, 2024

Run Gluten Clickhouse CI on x86

zzcclp
zzcclp approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@taiyang-li taiyang-li merged commit d75e90f into apache:main Dec 2, 2024
@taiyang-li taiyang-li mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zzcclp zzcclp zzcclp approved these changes

Assignees

No one assigned

Labels

CLICKHOUSE CORE works for Gluten Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CH] support TransformKeys

2 participants

@taiyang-li @zzcclp