[GLUTEN-7631][VL] Fall back lead/lag if input is foldable#8038
Merged
philo-he merged 1 commit intoapache:mainfrom Nov 27, 2024
Merged
[GLUTEN-7631][VL] Fall back lead/lag if input is foldable#8038philo-he merged 1 commit intoapache:mainfrom
philo-he merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Member
|
@zml1206, thanks for your pr! What's Velox's current behavior for this case? Will Velox interrupt with some error? |
Contributor
Author
The error reported by velox is the same as the error reported by gluten in the issue, "bad optional access".
|
Contributor
Author
philo-he
approved these changes
Nov 27, 2024
Contributor
Author
Thank you @philo-he |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What changes were proposed in this pull request?
Velox does not support lead/lag when its input is foldable.
(Fixes: #7631)
How was this patch tested?
UT