Skip to content

[GLUTEN-7600][VL] Simplify offload rules in RAS#7646

Merged
zhztheplayer merged 3 commits intoapache:mainfrom
zhztheplayer:wip-ras-offload
Oct 23, 2024
Merged

[GLUTEN-7600][VL] Simplify offload rules in RAS#7646
zhztheplayer merged 3 commits intoapache:mainfrom
zhztheplayer:wip-ras-offload

Conversation

@zhztheplayer
Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer commented Oct 23, 2024

This closes #7600

As special handling of empty schema input in OffloadHashAggregate was removed in #7620, we can simplify RAS rules in the same manner.

@github-actions github-actions bot added the CORE works for Gluten Core label Oct 23, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 23, 2024

#7600

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 23, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 23, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 23, 2024

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer merged commit cd77ce1 into apache:main Oct 23, 2024
@zhztheplayer zhztheplayer mentioned this pull request Oct 23, 2024
Closed
@GlutenPerfBot
Copy link
Copy Markdown
Contributor

GlutenPerfBot commented Oct 23, 2024

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_10_23_2024_time.csv log/native_master_10_22_2024_19090da33a_time.csv difference percentage
q1 14.50 14.43 -0.070 99.52%
q2 15.74 13.43 -2.309 85.33%
q3 5.21 5.31 0.097 101.86%
q4 72.95 72.37 -0.587 99.20%
q5 10.36 9.41 -0.944 90.88%
q6 2.42 2.35 -0.073 96.98%
q7 8.48 7.80 -0.685 91.92%
q8 3.57 5.46 1.898 153.21%
q9 26.65 24.93 -1.718 93.55%
q10 8.57 9.73 1.158 113.51%
q11 36.74 38.49 1.744 104.75%
q12 2.60 1.46 -1.140 56.09%
q13 6.48 6.42 -0.057 99.12%
q14a 48.49 47.96 -0.534 98.90%
q14b 42.71 43.18 0.474 101.11%
q15 2.39 2.53 0.146 106.10%
q16 48.75 48.66 -0.089 99.82%
q17 4.63 4.74 0.107 102.32%
q18 6.67 6.77 0.098 101.46%
q19 2.13 2.53 0.404 119.00%
q20 1.41 1.48 0.067 104.75%
q21 1.14 1.18 0.031 102.73%
q22 7.96 7.95 -0.010 99.87%
q23a 107.27 106.86 -0.406 99.62%
q23b 128.01 127.88 -0.126 99.90%
q24a 106.74 117.92 11.185 110.48%
q24b 106.54 110.48 3.941 103.70%
q25 3.95 6.25 2.299 158.26%
q26 7.20 4.41 -2.791 61.25%
q27 4.53 4.71 0.182 104.02%
q28 31.11 31.25 0.143 100.46%
q29 9.63 9.25 -0.382 96.04%
q30 4.90 4.94 0.036 100.74%
q31 6.85 7.72 0.865 112.62%
q32 1.26 1.14 -0.122 90.30%
q33 4.10 4.35 0.241 105.88%
q34 4.13 4.11 -0.023 99.44%
q35 7.60 8.01 0.407 105.35%
q36 5.26 5.87 0.608 111.55%
q37 5.03 5.08 0.049 100.97%
q38 13.68 14.16 0.485 103.54%
q39a 3.19 3.52 0.333 110.46%
q39b 3.04 3.10 0.067 102.20%
q40 4.13 3.88 -0.257 93.78%
q41 0.61 0.63 0.016 102.69%
q42 0.99 0.98 -0.008 99.16%
q43 4.80 5.31 0.511 110.66%
q44 9.07 8.63 -0.443 95.11%
q45 3.34 3.17 -0.167 95.00%
q46 3.89 3.99 0.095 102.43%
q47 17.77 17.79 0.029 100.16%
q48 5.16 5.46 0.293 105.68%
q49 6.69 6.54 -0.150 97.76%
q50 21.31 22.41 1.099 105.16%
q51 9.44 9.76 0.328 103.47%
q52 1.10 1.07 -0.024 97.86%
q53 2.33 2.42 0.094 104.03%
q54 3.96 3.76 -0.199 94.98%
q55 1.07 1.08 0.008 100.74%
q56 4.25 3.97 -0.272 93.59%
q57 10.43 10.58 0.149 101.43%
q58 2.44 2.61 0.178 107.30%
q59 10.85 10.87 0.023 100.21%
q60 4.05 4.53 0.473 111.68%
q61 4.11 3.92 -0.188 95.42%
q62 4.47 4.63 0.160 103.57%
q63 3.11 2.38 -0.726 76.65%
q64 62.85 60.91 -1.947 96.90%
q65 17.50 16.68 -0.817 95.33%
q66 4.57 4.36 -0.209 95.42%
q67 428.66 434.68 6.019 101.40%
q68 3.73 4.09 0.362 109.70%
q69 5.82 7.29 1.476 125.36%
q70 11.63 11.92 0.295 102.54%
q71 2.50 2.60 0.098 103.92%
q72 214.14 218.28 4.140 101.93%
q73 2.25 2.48 0.229 110.19%
q74 23.64 22.92 -0.718 96.96%
q75 28.23 26.99 -1.236 95.62%
q76 14.10 13.52 -0.581 95.88%
q77 2.25 2.18 -0.072 96.81%
q78 49.54 49.31 -0.233 99.53%
q79 3.92 3.92 0.005 100.13%
q80 11.53 11.76 0.229 101.98%
q81 4.64 4.61 -0.039 99.17%
q82 6.90 7.78 0.882 112.79%
q83 1.61 1.59 -0.017 98.95%
q84 2.90 2.71 -0.192 93.39%
q85 6.58 7.97 1.382 120.99%
q86 4.99 4.30 -0.689 86.20%
q87 13.61 15.28 1.673 112.29%
q88 18.03 18.13 0.098 100.54%
q89 3.32 3.37 0.053 101.59%
q90 3.02 2.99 -0.034 98.87%
q91 2.27 2.38 0.114 105.04%
q92 1.15 1.34 0.188 116.37%
q93 45.16 42.29 -2.874 93.64%
q94 27.11 27.38 0.273 101.01%
q9 89.56 89.59 0.026 100.03%
q5 2.53 2.97 0.438 117.30%
q96 18.05 18.13 0.077 100.43%
q97 1.96 1.87 -0.089 95.45%
q98 11.32 11.69 0.370 103.27%
q99 11.32 11.69 0.370 103.27%
total 2235.53 2260.23 24.702 101.10%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JkSelf JkSelf JkSelf approved these changes

Assignees

No one assigned

Labels

CORE works for Gluten Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[VL] Rework the workaround for empty schema batch

3 participants

@zhztheplayer @GlutenPerfBot @JkSelf