Skip to content

[GLUTEN-6067][CH][MINOR][UT] Pass backends-clickhouse ut in Spark 3.5#6623

Merged
baibaichen merged 2 commits intoapache:mainfrom
baibaichen:feature/tpc-TEST
Jul 31, 2024
Merged

[GLUTEN-6067][CH][MINOR][UT] Pass backends-clickhouse ut in Spark 3.5#6623
baibaichen merged 2 commits intoapache:mainfrom
baibaichen:feature/tpc-TEST

Conversation

@baibaichen
Copy link
Copy Markdown
Contributor

@baibaichen baibaichen commented Jul 29, 2024

What changes were proposed in this pull request?

Move tpch/tpcds parquet test to tpch/tpcds package, so that we can run these tests in spark-3.5 ut

(Fixes: #6067)

How was this patch tested?

Using Existed UTs

@github-actions
Copy link
Copy Markdown

#6067

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@baibaichen baibaichen changed the title [GLUTEN-6067][CH][MINOR][UT] Move tpch/tpcds parquet test tpch/tpcds package [GLUTEN-6067][CH][MINOR][UT] Move tpch/tpcds parquet test to tpch/tpcds package Jul 29, 2024
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@baibaichen
Copy link
Copy Markdown
Contributor Author

image

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc self-requested a review July 30, 2024 00:28
lgbo-ustc
lgbo-ustc previously approved these changes Jul 30, 2024
taiyang-li
taiyang-li previously approved these changes Jul 30, 2024
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@baibaichen baibaichen changed the title [GLUTEN-6067][CH][MINOR][UT] Move tpch/tpcds parquet test to tpch/tpcds package [GLUTEN-6067][CH][MINOR][UT] Pass backends-clickhouse ut in Spark 3.5 Jul 31, 2024
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

2. move tpcds ut to tpcds package
3. pass ut in spark 3.5
1. isSparkVersionGE("3.5")
2. isSparkVersionLE("3.3")
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@baibaichen baibaichen merged commit e8583c3 into apache:main Jul 31, 2024
@baibaichen baibaichen deleted the feature/tpc-TEST branch July 31, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CH] Support CH backend with Spark 3.5.x

4 participants