#4424

Run Gluten Clickhouse CI

We usually take 3 steps to add a Spark version.

1. pass compile, add related code to shims, adding support to the new features
2. pass TPCH/DS
3. pass UTs

@FelixYBW: Do you mean those three steps would be in separate PRs?

@FelixYBW: Do you mean those three steps would be in separate PRs?

Yes, may be many PRs, let's solve this one by one.

Run Gluten Clickhouse CI

The style issue can be fixed with spotless
mvn spotless:apply -Pspark-3.2 clean package

@holdenk
Thank you very much for your work on the 3.5 version. Based on the experience of supporting 3.4, we can further split this PR, which will accelerate the progress of our review. This first PR only needs to ensure that the compilation can pass and make the necessary shim code changes. We can enable TPCH/DS in the second PR. Of course, if the first PR has already enabled TPCH/DS , we won't need the second PR. Next, we can enable unit tests. If there are many failed ut, we can list these failed ut first and then open separate PRs to address them later.

Can you help to resolve the conflicts and format issue firstly? And also remove the ut changes from this PR? If you don't have much time, I can take over this task. Looking forward to your reply. Thanks.

I was going to wait for the 3.5.1 release to be ready on the Spark side (it's very close) and then continue on the PR. I can split the test changes out, personally I don't like merging code without tests or with failing tests but if that's the way y'all do it I can split it.

I was going to wait for the 3.5.1 release to be ready on the Spark side (it's very close) and then continue on the PR. I can split the test changes out, personally I don't like merging code without tests or with failing tests but if that's the way y'all do it I can split it.

The reason is based on our experience, fixing unit tests may require a long time, so we usually split the support patch into several parts, otherwise it will be a very big PR

thanks,
-yuan

Spark 3.5.1 has been officially released. https://spark.apache.org/releases/spark-release-3-5-1.html

Yup, I'm going on vacation though until next Thursday so it you want to take it over go for it otherwise I can take a look when I'm back.

Yup, I'm going on vacation though until next Thursday so it you want to take it over go for it otherwise I can take a look when I'm back.

Sure, I will handle the task for 351 and ensure you receive the credit. Thank you for your efforts.

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.