[VL] Improve native write files fallback#4329
Merged
ulysses-you merged 3 commits intoapache:mainfrom Jan 10, 2024
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
2 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
67cde0a to
1622174
Compare
|
Run Gluten Clickhouse CI |
Contributor
Author
|
cc @JkSelf thank you |
1622174 to
a53db57
Compare
|
Run Gluten Clickhouse CI |
JkSelf
reviewed
Jan 10, 2024
Contributor
JkSelf
left a comment
There was a problem hiding this comment.
Thanks for your improvement. LGTM except one small comments.
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala
Show resolved
Hide resolved
JkSelf
reviewed
Jan 10, 2024
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If people set maxRecordsPerFile, then we should fallback to vanilla Spark write files. This pr also moves the write files transformer validation to velox backend.
How was this patch tested?
enable test