[GLUTEN-11550][CORE][UT] Fix GlutenSingleJoinSuite for Spark 4.0+#11577
Merged
baibaichen merged 1 commit intoapache:mainfrom Feb 6, 2026
Merged
[GLUTEN-11550][CORE][UT] Fix GlutenSingleJoinSuite for Spark 4.0+#11577baibaichen merged 1 commit intoapache:mainfrom
baibaichen merged 1 commit intoapache:mainfrom
Conversation
## What changes were proposed in this pull request? Add support for LeftSingle join type to enable proper fallback to Spark execution in Spark 4.0+. ## Why are the changes needed? LeftSingle is a new join type introduced in Spark 4.0 for scalar subquery correlation. When Gluten encounters this join type, it should gracefully fall back to Spark execution since Substrait does not support it yet. Before this fix, the test `GlutenSingleJoinSuite` failed with: ``` IllegalArgumentException: ShuffledHashJoinExecTransformer not take LeftSingle as the JoinType ``` The root cause was that exceptions were thrown during plan transformation (when accessing `output`/`schema` properties) before validation could detect the unsupported join type and trigger fallback. ## How was this patch tested? - All 36 tests in GlutenSingleJoinSuite pass for both Spark 4.0 and 4.1 - Verified fallback works correctly with log message: "Validation failed for plan: ShuffledHashJoin, due to: - Unsupported join type of LeftSingle for substrait: UNRECOGNIZED" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Run Gluten Clickhouse CI on x86 |
Surbhi-Vijay
approved these changes
Feb 6, 2026
Contributor
Author
|
@zhouyuan @zhztheplayer pelase review this pr |
zhztheplayer
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add support for LeftSingle join type to enable proper fallback to Spark execution in Spark 4.0+.
LeftSingle is a new join type introduced in Spark 4.0 for scalar subquery correlation. When Gluten encounters this join type, it should gracefully fall back to Spark execution since Substrait does not support it yet.
This enables
GlutenSingleJoinSuiteto pass for both Spark 4.0 and 4.1.Fix #11550
How was this patch tested?
"Validation failed for plan: ShuffledHashJoin, due to: Unsupported join type of LeftSingle for substrait: UNRECOGNIZED"
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.5