[GLUTEN-11088][VL] Add compatibility layer for StructsToJson and StaticInvoke expressions across Spark versions#11294
Merged
baibaichen merged 5 commits intoapache:mainfrom Dec 16, 2025
Conversation
|
Run Gluten Clickhouse CI on x86 |
added 4 commits
December 15, 2025 10:09
… Spark versions and remove Spark-version-specific test limitations
5f191c0 to
bd3d052
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses Spark 4.0 compatibility issues and refactors the ExpressionConverter to improve code quality.
Main Changes:
Add compatibility layer for
StructsToJsonexpression across Spark versionsStructsToJsonwas replaced withInvokeexpression usingStructsToJsonEvaluatorStructsToJsonInvokeextractor in shims for all Spark versions (3.2-4.0) to provide a unified interfaceAdd support for
StaticInvokeexpressions in Spark 4.0lengthOfJsonArrayandjsonObjectKeysnow useStaticInvokein Spark 4.0Refactor
ExpressionConverterto reducereturnusagereturnstatements, following Scala best practicesWhy are the changes needed?
StructsToJsonwas replaced withInvokeexpressionsreturnkeyword is discouraged in Scala as it breaks functional programming style and can lead to unexpected behaviorDoes this PR introduce any user-facing change?
No. This is an internal compatibility fix.
How was this patch tested?
JsonFunctionsValidateSuiteRelated issue: #11088