[GLUTEN-11088][VL] Fix Spark4.0 varchar type check suites#11202
Merged
zhouyuan merged 2 commits intoapache:mainfrom Nov 27, 2025
Merged
[GLUTEN-11088][VL] Fix Spark4.0 varchar type check suites#11202zhouyuan merged 2 commits intoapache:mainfrom
zhouyuan merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
reviewed
Nov 27, 2025
| } | ||
| } | ||
|
|
||
| testGluten("length check for input string values: nested in map key") { |
Member
There was a problem hiding this comment.
It seems these tests are still valid in original Spark tests
Contributor
Author
There was a problem hiding this comment.
Yes, I override assertLengthCheckFailure to test the test result as PR description
Contributor
Author
There was a problem hiding this comment.
Spark 4.0 does a refactor, move the test result check to a public function, so we can override this function
Contributor
Author
|
Do you have further comments? @zhouyuan |
zhouyuan
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use one test to make sure the native code is really called, override function assertLengthCheckFailure to assert result correct.
Related issue: #11088