Skip to content

[GLUTEN-10387][VL] Set ANSI mode for Velox according to Spark's configuration#10385

Merged
philo-he merged 5 commits intoapache:mainfrom
philo-he:enable-ansi-config
Sep 1, 2025
Merged

[GLUTEN-10387][VL] Set ANSI mode for Velox according to Spark's configuration#10385
philo-he merged 5 commits intoapache:mainfrom
philo-he:enable-ansi-config

Conversation

@philo-he
Copy link
Copy Markdown
Member

@philo-he philo-he commented Aug 8, 2025

What changes were proposed in this pull request?

This is a preparation for supporting ANSI mode. Depends on Velox PR: facebookincubator/velox#14375

Fixes #10387.

How was this patch tested?

Local test.

@github-actions github-actions bot added CORE works for Gluten Core BUILD VELOX labels Aug 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

Run Gluten Clickhouse CI on x86

@philo-he philo-he changed the title [WIP][VL] Set ANSI mode for Velox according to Spark's configuration [WIP][GLUTEN-10387][VL] Set ANSI mode for Velox according to Spark's configuration Aug 8, 2025
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions github-actions bot removed the BUILD label Sep 1, 2025
@philo-he philo-he marked this pull request as ready for review September 1, 2025 08:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 1, 2025

Run Gluten Clickhouse CI on x86

@philo-he philo-he changed the title [WIP][GLUTEN-10387][VL] Set ANSI mode for Velox according to Spark's configuration [GLUTEN-10387][VL] Set ANSI mode for Velox according to Spark's configuration Sep 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 1, 2025

#10387

@philo-he
Copy link
Copy Markdown
Member Author

philo-he commented Sep 1, 2025

@zhli1142015, could you take a look?

@philo-he philo-he merged commit 4a84937 into apache:main Sep 1, 2025
56 of 57 checks passed
@philo-he philo-he deleted the enable-ansi-config branch September 1, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VL] Set ANSI mode for Velox according to Spark's configuration

2 participants